useTour re-render many times when i proceed to scroll

[toduyen]

I tried putting console.log where useTour() is declared and after each step my component is re-rendered many times and even when scrolling horizontally or vertically is re-rendered.

[elrumordelaluz]

Hi @toduyen, thanks for open the Issue.

Mind creating a minimal reproduction in a sandbox in order to allow others to debug your use-case and try to find a solution? Thanks!

[elrumordelaluz]

a bit of maybe related threads:

facebook/react#22257 (comment)

https://stackoverflow.com/a/69104314/1920004

[elrumordelaluz]

could you please try updating to the last version?

[toduyen]

Hi @elrumordelaluz My latest version is 3.1.4

[toduyen]

This is the TourProvider. mine. But every time I declare useTour in a certain part, every change like vertical and horizontal scrolling causes re-render as video. @elrumordelaluz

[elrumordelaluz]

could you please try to upgrade into v3.1.5?

[toduyen]

ok bro @elrumordelaluz

[elrumordelaluz]

great, please let me know.

[toduyen]

even though the multiple render issue has been resolved, I still get the setCurrentStep error and the console.log currentstep doesn't change. @elrumordelaluz with version 3.1.5

[toduyen]

Too bad when I change the version it seems that useTour crashes ( setCurrentStep , currentstep ) Not woking @elrumordelaluz

[toduyen]

And when I changed to your new version my program crashed a lot. Please help me to solve this problem.

[elrumordelaluz]

ok, rolled back the last changes, please use v3.1.6 and please give an eye here https://reactour.vercel.app/ where I added a console.log for testing purposes in the same Component where is present useTour hook, and check if has the same behavior than on your case.

[toduyen]

ok bro i will try your latest version

[elrumordelaluz]

did you tried the online demo here https://reactour.vercel.app, looking at the log and making the same changes you made with window sizes and so on? The last version is a roll-back, so it is expected to behave as the previous one.

Please compare your use-case with the online demo.

[toduyen]

thank you i made it. because my source code uses the global window.innerWidth object. New resulted in re-rendering above. I have successfully fixed it but I also hope in future reactour updates to limit the re-render when moving to other steps. Thank you very much bro @elrumordelaluz

[elrumordelaluz]

Cool, so I am closing this issue, but feel free to re-open or create a new one in any case.