Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv-safe instead of manual checking a hardcodet whitelist #111

Open
Sharaal opened this issue Jan 25, 2018 · 1 comment
Open

dotenv-safe instead of manual checking a hardcodet whitelist #111

Sharaal opened this issue Jan 25, 2018 · 1 comment
Assignees
Milestone

Comments

@Sharaal
Copy link

Sharaal commented Jan 25, 2018

Instead of:
https://github.com/wearehive/project-guidelines/blob/4baf60bab3fc3d4616712b04f3dab48a3774d20c/config.sample.js#L1-L9

Maybe its an idea to use dotenv-safe, with that you can define the needed env variables in the .env.example (the optional ones can be prefixed with # ).

@vpanjganj vpanjganj self-assigned this Nov 22, 2018
@bhgsbatista
Copy link

I second this, less code, less things to think about. The .gitignore example file would also need to be fixed, since it currently ignores .env* files.

@vpanjganj vpanjganj added this to the Maintenance milestone Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants