New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember-Source 5 #886

Closed

hexadecy opened this issue Oct 5, 2023 · 1 comment · Fixed by #893

Contributor

hexadecy commented Oct 5, 2023 •

edited

Loading

When installing:

warning " > ember-sinon-qunit@7.1.4" has incorrect peer dependency "ember-source@^3.28.0 || ^4.0.0".

Suggested fix for package.json:

"peerDependencies": {
  "ember-source": "^3.28.0 || ^4.0.0 || >=5.0.0",
  "qunit": "^2.0.0",
  "sinon": "^15.0.3 || ^16.0.0"
},

Owner

elwayman02 commented Oct 5, 2023

Happy to accept a PR for this change! My bandwidth is pretty low right now but I'll try to get to it in the next couple months otherwise.

hexadecy mentioned this issue

Add ember-source 5 support #888

Closed

SergeAstapov linked a pull request

that will close this issue

Add ember-source 5 support #893

Merged

elwayman02 closed this as completed in #893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment