Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use box plots or violin plots instead of a line chart #101

Open
kolgza opened this issue Apr 26, 2020 · 5 comments
Open

[FEATURE] Use box plots or violin plots instead of a line chart #101

kolgza opened this issue Apr 26, 2020 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kolgza
Copy link

kolgza commented Apr 26, 2020

The current use of overlapping line plots makes it difficult to clearly understand the probability that turnips would be a given price on a given day. In addition, the use of a line chart subtly implies that the price of turnips is a continuous function, which it is not.

A much more ideal visualization would be a box plot or a violin plot. Personally, I prefer box plots, because I find them more intuitive. However, @mikebryant, the maintainer of Turnip Prophet, stated that he preferred violin plots because they are more detailed.
visual description of a box plot

I originally brought this issue up here.

@kolgza kolgza added the enhancement New feature or request label Apr 26, 2020
@elxris elxris added the help wanted Extra attention is needed label Apr 27, 2020
@elxris
Copy link
Owner

elxris commented Apr 27, 2020

Related: #78, #6

@elxris
Copy link
Owner

elxris commented May 18, 2020

Please review this comment: #115 (comment) and let me know what you think.

@elxris
Copy link
Owner

elxris commented May 26, 2020

Hi @kolgza, we now have a new chart that uses this idea of quartiles. But it doesn't use box/violin plots yet. Can you share some thoughts around it?
image

@kolgza
Copy link
Author

kolgza commented May 26, 2020

I find it a bit confusing. It's not immediately clear that 50% of the possible outcomes fall within the "Most Likely" area. I think that the "Maximum" and "Minimum" graphs should be one in the same.

EDIT: By "one in the same," I mean that the "Maximum" and "Minimum" ranges should be given the same color and label.

@kolgza
Copy link
Author

kolgza commented May 26, 2020

I think better labels would be "Interquartile Range" to replace "Most Likely," with "Full Range" to be the combined "Minimum" and "Maximum." There should also be a tooltip for Interquartile Range to say something along the lines of "50% of all possible outcomes fall within this range."

Although this chart is an improvement, it still displays turnip prices as a continuous function. I'm not sure if you have outright plans to switch to violin plots, but they truly would be a more appropriate way of displaying this type of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants