Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support *.css files by default #138

Closed
2 tasks
elycruz opened this issue Jun 25, 2024 · 3 comments
Closed
2 tasks

feat: support *.css files by default #138

elycruz opened this issue Jun 25, 2024 · 3 comments

Comments

@elycruz
Copy link
Owner

elycruz commented Jun 25, 2024

Currently (with #131 ) the plugin supports *.css files (by adding inclusion of them (via option include)), however it might be cumbersome to have to specify you want to support *.css files, in given projects, due to possibly not remembering that you have to specify support for *.css file extension.

Acceptance Criteria

  • Add **/*.css in the plugins defaultIncludes array.
  • Unit tests showing a working example.
@elycruz elycruz changed the title feat: support *.css by default feat: support *.css files by default Jun 25, 2024
@08AHAD
Copy link

08AHAD commented Jun 25, 2024

please assign me this issue

@elycruz
Copy link
Owner Author

elycruz commented Jun 25, 2024

Assigned.

@elycruz
Copy link
Owner Author

elycruz commented Aug 18, 2024

We're not going to attempt to support *.css to *.css compilation for now as 'dart-sass', and other sass-only compilers don't directly support css imports (@import url('...*.css') - We're leaving this functionality to other plugins/libraries to handle.

@elycruz elycruz closed this as completed Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants