Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert option + chunks places ___$insertStyle function in every chunked file #69

Closed
mcshaz opened this issue Apr 11, 2020 · 0 comments · Fixed by #139
Closed

insert option + chunks places ___$insertStyle function in every chunked file #69

mcshaz opened this issue Apr 11, 2020 · 0 comments · Fixed by #139
Assignees
Labels
bug triaged Deprecated - Use "groomed" instead.

Comments

@mcshaz
Copy link

mcshaz commented Apr 11, 2020

When rollup is run with

   output: { fomat: 'esm',
      ...
   plugins: [rollupPluginSass({insert:true}), ...

multiple chunks (which don't import any css) have the insert css function ___$insertStyle needlessly placed at the top of each chunked file.

ideally this function to insert a style element into the header would be added earlier in the rollup build pipeline so that it could be chunked to a single, appropriate file.

Edit

After having created this issue I saw there have been no commits to this repository for 13 months (at the time of writing). if anyone is a bit stuck on this issue, I moved to rollup-plugin-postcss which works as expected (only placing the insert css function once in the bundle of outputs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triaged Deprecated - Use "groomed" instead.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants