Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update classes in metadata-common into react components #2590

Open
ajbozarth opened this issue Mar 24, 2022 · 2 comments
Open

Update classes in metadata-common into react components #2590

ajbozarth opened this issue Mar 24, 2022 · 2 comments
Labels
status:Needs Triage

Comments

@ajbozarth
Copy link
Member

Describe the issue
Currently MetadataEditorTags and FilterTools are defined as classes that extend React.Component. This is causing some race conditions with their state such as when handling tags. The bug would be easy to address using useEffect if we rewrote the classes as components as we did with many classes in pipeline-editor.
@ajbozarth
Copy link
Member Author

note that this was found when addressing warnings in #2570

@karlaspuldaro
Copy link
Member

Relevant reference info #1594 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:Needs Triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajbozarth @karlaspuldaro