Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circe-Lagmon sends CTCP requests which are confusing for other clients/cause notifications #419

Open
Thaodan opened this issue Apr 29, 2024 · 1 comment

Comments

@Thaodan
Copy link
Contributor

Thaodan commented Apr 29, 2024

I noticed when using Circe-Lagmon on connections that use a bouncer together with other clients they can be confused or cause spam.

Since other clients treat the CTCP requests from circe as literal like it would be requested by another user they cause spam, each time a CTCP requests is answered the cause a notification.

@wasamasa
Copy link
Collaborator

wasamasa commented Jun 2, 2024

If circe-lagmon.el were changed to use the existing PING/PONG commands for this purpose (or more realistically, if a new Circe module were written that implements the lagmon functionality using PING/PONG), I'd expect this issue to disappear. One concern against doing things this way was raised in #6:

  • The IRC RFC does not guarantee that when sending an extra argument with the PING/PONG command, the corresponding response command would also include that extra argument. However, according to https://modern.ircdocs.horse/#ping-message this can actually be relied upon (not too surprisingly since it's been more than 10 years since the linked GitHub issue!). In the case a server does not implement it, lag detection can still be disabled.

That leaves actually implementing this. My IRC knowledge regarding the protocol itself is limited. Help is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants