Skip to content

Commit

Permalink
fix(@embark/contracts_manager): compare correct property
Browse files Browse the repository at this point in the history
Compare a contract's `originalFilename` property to a contract file's
normalized `originalPath` property instead of `filename`. The `filename`
property seems to have been removed.
  • Loading branch information
michaelsbradleyjr authored and iurimatias committed Apr 11, 2019
1 parent 88c9a60 commit 06dcbd0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions packages/embark/src/lib/modules/contracts_manager/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
let async = require('async');
const cloneDeep = require('clone-deep');

const path = require('path');
const utils = require('../../utils/utils.js');
const constants = require('../../constants');

Expand Down Expand Up @@ -260,7 +260,6 @@ class ContractsManager {

build(done, _useContractFiles = true, resetContracts = true) {
let self = this;
self.contracts = {};

if(resetContracts) self.contracts = {};
async.waterfall([
Expand All @@ -287,7 +286,7 @@ class ContractsManager {
self.contractsFiles &&
self.contractsFiles.every(contractFile =>
Object.values(self.compiledContracts).find(contract =>
contract.originalFilename === contractFile.filename
contract.originalFilename === path.normalize(contractFile.originalPath)
)
);
callback(null, allContractsCompiled);
Expand Down

0 comments on commit 06dcbd0

Please sign in to comment.