Skip to content

Commit

Permalink
feat(@embark/core): Support minimum truffle projects
Browse files Browse the repository at this point in the history
When taking a bare-minimum truffle project, created from the [`metacoin` truffle box](https://github.com/truffle-box/metacoin-box), there were only two steps that needed to happen as a prerequisite:
1. First, run `embark init`, creating a default `embark.json`
2. Second, run `npm init`, creating a default `package.json`.

Trying to run `embark run` before those prequisites would error with appropriate directions in the console, guiding the user to run those steps explicitly.

After running these two steps, Embark would hang waiting for the namesystem plugin to come up.

Changing the default namesystem config to disabled allows Embark to start up successfully without hanging.

The rationale behind this decision is that if `embark.json` doesn’t exist, then we cannot expect that the namesystem plugin will be installed in the project either, and thefore its default value should be disabled.
  • Loading branch information
emizzle authored and 0x-r4bbit committed Mar 23, 2020
1 parent 469504f commit a454ae8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/core/core/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ export class Config {
loadCommunicationConfigFile() {
const configObject = {
default: {
enabled: true,
enabled: false,
provider: "whisper",
available_providers: ["whisper"],
client: "geth",
Expand Down

0 comments on commit a454ae8

Please sign in to comment.