feat: support Node.js v12.x and newer

Remove the `<12.0.0` restriction re: Node.js version in the `"engines"` settings for all the packages in the monorepo that had that restriction. Add missing `"engines"` settings in `packages/plugins/snark/package.json`. Adjust the Azure Pipelines config to include builds for Node.js v12.x and v13.x. Bump `solc` to `0.4.26` in `dapps/tests/app` and `dapps/tests/contracts`. It was discovered that older versions suffered a fatal `Maximum call stack size exceeded` error when run on Windows with Node.js v12.x or newer. Display a warning re: the bad combo (solc version + Windows + Node version) if it's detected at runtime. Adjust the root `yarn.lock` so that the `sha3` transitive dependency resolves to a newer version that is compatible with Node v13.x.
embarklabs · Jan 20, 2020 · c093cf8 · c093cf8
1 parent a224401
commit c093cf8
Show file tree

Hide file tree

Showing 76 changed files with 110 additions and 76 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -5,6 +5,8 @@ variables:
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
   ipfsVersion: '0.4.22'
   node10: '^10.17.0'
+  node12: '^12.0.0'
+  node13: '^13.0.0'
   pythonVersion: '2.7.x'
   yarnVersion: '1.19.1'
 
@@ -19,6 +21,24 @@ strategy:
     Node 10 / Windows:
       nodeVersion: $(node10)
       imageName: 'vs2017-win2016'
+    Node 12 / Linux:
+      nodeVersion: $(node12)
+      imageName: 'ubuntu-18.04'
+    Node 12 / macOS:
+      nodeVersion: $(node12)
+      imageName: 'macos-10.14'
+    Node 12 / Windows:
+      nodeVersion: $(node12)
+      imageName: 'vs2017-win2016'
+    Node 13 / Linux:
+      nodeVersion: $(node13)
+      imageName: 'ubuntu-18.04'
+    Node 13 / macOS:
+      nodeVersion: $(node13)
+      imageName: 'macos-10.14'
+    Node 13 / Windows:
+      nodeVersion: $(node13)
+      imageName: 'vs2017-win2016'
 
 pool:
   vmImage: $(imageName)

diff --git a/dapps/tests/app/embark.json b/dapps/tests/app/embark.json
@@ -15,7 +15,7 @@
   "buildDir": "dist/",
   "config": "config/",
   "versions": {
-    "solc": "0.4.25"
+    "solc": "0.4.26"
   },
   "plugins": {
     "embark-dapp-test-service": {}

diff --git a/dapps/tests/contracts/contracts.json b/dapps/tests/contracts/contracts.json
@@ -1,7 +1,7 @@
 {
   "default": {
     "versions": {
-      "solc": "0.4.24"
+      "solc": "0.4.26"
     },
     "dappConnection": [
       "$EMBARK",

diff --git a/dapps/tests/contracts/embark.json b/dapps/tests/contracts/embark.json
@@ -12,7 +12,7 @@
     "namesystem": "ens.json"
   },
   "versions": {
-    "solc": "0.4.24"
+    "solc": "0.4.26"
   },
   "plugins": {
   }

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
     "semver": "5.6.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/cockpit/api-client/package.json b/packages/cockpit/api-client/package.json
@@ -56,7 +56,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/cockpit/ui/package.json b/packages/cockpit/ui/package.json
@@ -120,7 +120,7 @@
     ]
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/code-runner/package.json b/packages/core/code-runner/package.json
@@ -74,7 +74,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/core/console/package.json b/packages/core/console/package.json
@@ -72,7 +72,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/core/core/package.json b/packages/core/core/package.json
@@ -79,7 +79,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/engine/package.json b/packages/core/engine/package.json
@@ -103,7 +103,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/i18n/package.json b/packages/core/i18n/package.json
@@ -58,7 +58,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/logger/package.json b/packages/core/logger/package.json
@@ -56,7 +56,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/reset/package.json b/packages/core/reset/package.json
@@ -39,7 +39,7 @@
     "npm-run-all": "4.1.5"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/core/utils/package.json b/packages/core/utils/package.json
@@ -84,7 +84,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embark/package.json b/packages/embark/package.json
@@ -158,13 +158,13 @@
     "sinon": "4.5.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },
   "runtime": {
     "engines": {
-      "node": ">=10.17.0 <12.0.0"
+      "node": ">=10.17.0"
     }
   }
 }
diff --git a/packages/embarkjs/embarkjs/package.json b/packages/embarkjs/embarkjs/package.json
@@ -82,7 +82,7 @@
     "web3": "1.2.4"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embarkjs/ens/package.json b/packages/embarkjs/ens/package.json
@@ -61,7 +61,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embarkjs/ipfs/package.json b/packages/embarkjs/ipfs/package.json
@@ -59,7 +59,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embarkjs/swarm/package.json b/packages/embarkjs/swarm/package.json
@@ -60,7 +60,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embarkjs/web3/package.json b/packages/embarkjs/web3/package.json
@@ -59,7 +59,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/embarkjs/whisper/package.json b/packages/embarkjs/whisper/package.json
@@ -60,7 +60,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/accounts-manager/package.json b/packages/plugins/accounts-manager/package.json
@@ -63,7 +63,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/basic-pipeline/package.json b/packages/plugins/basic-pipeline/package.json
@@ -96,7 +96,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/plugins/coverage/package.json b/packages/plugins/coverage/package.json
@@ -73,7 +73,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/debugger/package.json b/packages/plugins/debugger/package.json
@@ -57,7 +57,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/deploy-tracker/package.json b/packages/plugins/deploy-tracker/package.json
@@ -62,7 +62,7 @@
     "sinon": "7.4.1"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/plugins/ens/package.json b/packages/plugins/ens/package.json
@@ -95,7 +95,7 @@
     }
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/ethereum-blockchain-client/package.json b/packages/plugins/ethereum-blockchain-client/package.json
@@ -62,7 +62,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/ganache/package.json b/packages/plugins/ganache/package.json
@@ -55,7 +55,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/geth/package.json b/packages/plugins/geth/package.json
@@ -68,7 +68,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/graph/package.json b/packages/plugins/graph/package.json
@@ -56,7 +56,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/ipfs/package.json b/packages/plugins/ipfs/package.json
@@ -66,7 +66,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/mocha-tests/package.json b/packages/plugins/mocha-tests/package.json
@@ -68,7 +68,7 @@
     "source-map-support": "0.5.13"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/nethermind/package.json b/packages/plugins/nethermind/package.json
@@ -60,7 +60,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/parity/package.json b/packages/plugins/parity/package.json
@@ -62,7 +62,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/plugin-cmd/package.json b/packages/plugins/plugin-cmd/package.json
@@ -48,7 +48,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/profiler/package.json b/packages/plugins/profiler/package.json
@@ -58,7 +58,7 @@
     "rimraf": "3.0.0"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }

diff --git a/packages/plugins/rpc-manager/package.json b/packages/plugins/rpc-manager/package.json
@@ -67,7 +67,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   },

diff --git a/packages/plugins/scaffolding/package.json b/packages/plugins/scaffolding/package.json
@@ -64,7 +64,7 @@
     "typescript": "3.7.2"
   },
   "engines": {
-    "node": ">=10.17.0 <12.0.0",
+    "node": ">=10.17.0",
     "npm": ">=6.11.3",
     "yarn": ">=1.19.1"
   }