Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(plugins/solc): don't read pluginConfig from plugin.config
In #2330 (comment) we've changed the `solc` plugin to read its `pluginConfig` from `embark.config`. This was done under the assumption that the `embark.config` is always properly populated with a dedicated `pluginConfig`. In our testing environment we pass `Embark` objects to plugins, while in reality, we pass `Plugin` instances. These two are different in nature, so relying on `embark.config` inside the plugin seemed the most pragmatic way forward without introducing a bigger refactoring in the testing APIs. Unfortunately it turned out that `embark.config` isn't populated with a `pluginConfig` which essentially caused it to break apps. This commit reverts that change done in the mentioned PR and patches the Embark testing API to behave like a `Plugin` while still being an `Embark` instance.
- Loading branch information