Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing entries for UART DE pins for H7RS #3774

Open
williams-one opened this issue Jan 15, 2025 · 3 comments
Open

Missing entries for UART DE pins for H7RS #3774

williams-one opened this issue Jan 15, 2025 · 3 comments

Comments

@williams-one
Copy link
Contributor

I think that the assignment for DriverEnable pins is missing for H7RS

The datasheet reports them as being shared with RTS pins
image

But there is no corresponding entry pin_trait_impl!(crate::usart::DePin, UARTXX, XXX, XXX); in the generated data

I think that the root cause of the problem is that there is no entry for _DE pins in the .xml descriptors such as stm32-data\sources\cubedb\mcu\STM32H7S7L8HxH.xml
image

If this is an actual problem I can help with the fix, but I need some guidance since I don't know exactly where to apply the fix. Here or in stm32-data and where to exactly put the override...

@Dirbaio
Copy link
Member

Dirbaio commented Jan 21, 2025

ideally we should avoid adding overrides in embassy-stm32 for bad data, so fix should be in stm32-data.

If it really is the case that all RTSs are also DEs and all CTSs are NSSs then some well-placed if in stm32-data-gen should do the trick.

@williams-one
Copy link
Contributor Author

OK. I have also double checked the xml data from STM sources https://github.com/STMicroelectronics/STM32_open_pin_data and it looks that they have fixed the peripheral description in CubeMx 6.13 release STMicroelectronics/STM32_open_pin_data@3e9ade9

Image

I have seen that stm32-data is using sources from an older CubeMx release. I imagine that moving to a new one would mess up a lot of things in embassy since ST always keep changing things :(

But do you think that it could be possible to patch just the descriptor files for H7RS in stm32-data-sources? Or should I go on with the manual override?

@williams-one
Copy link
Contributor Author

Oh and by the way... NSS pins are fine also in the old xml. Only DE pins are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants