Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs has outdated style for custom transition #627

Open
samselikoff opened this issue Nov 7, 2018 · 1 comment
Open

Docs has outdated style for custom transition #627

samselikoff opened this issue Nov 7, 2018 · 1 comment

Comments

@samselikoff
Copy link
Contributor

samselikoff commented Nov 7, 2018

Believe the docs has an example showing an older API for writing custom transitions:

https://ember-animation.github.io/liquid-fire/transition-map/choosing-transitions

// You can also provide an implementation instead of a name, though
// it's probably better to keep implementations in separate files. We
// talk more about transition implementations in the next section.
import { animate, stop } from "liquid-fire";
this.transition(
  this.withinRoute('foo'),
  this.use(function(oldView, insertNewView, opts) {
    stop(oldView);
    return animate(oldView, {opacity: 0}, opts)
      .then(insertNewView)
      .then(function(newView){
        return animate(newView, {opacity: [1, 0]}, opts);
      });
  })
);

If this is correct I can submit a PR

@ef4
Copy link
Collaborator

ef4 commented Nov 22, 2018

You're correct, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants