Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic or configurable hostname (besides localhost) #8

Closed
xomaczar opened this issue Oct 6, 2014 · 3 comments · Fixed by #10
Closed

Support dynamic or configurable hostname (besides localhost) #8

xomaczar opened this issue Oct 6, 2014 · 3 comments · Fixed by #10

Comments

@xomaczar
Copy link

xomaczar commented Oct 6, 2014 

if (liveReloadPort && type === 'head') {
      return '<script src="http://localhost:' + liveReloadPort + '/livereload.js?snipver=1" type="text/javascript"></script>';
    }
@xomaczar xomaczar changed the title Support dynamic or configurable hostname (not simply localhost) Support dynamic or configurable hostname (besides localhost) Oct 6, 2014
@pgasiorowski
Copy link

Please vote up #5 XD

@rwjblue
Copy link
Member

rwjblue commented Oct 6, 2014

Yes, agreed. This is related to https://github.com/rwjblue/ember-cli-inject-live-reload/pull/5.

@xomaczar
Copy link
Author

xomaczar commented Oct 7, 2014

Agree. This is a duplicate.
@rwjblue Any plans to merge this in?
@WooDzu Any plans to support "dynamic" hostname?

@rwjblue rwjblue mentioned this issue Oct 13, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamically generate livereload script. ember-cli/ember-cli-inject-live-reload
3 participants
@rwjblue @xomaczar @pgasiorowski