use should() with chai

[shaunc]

I'm having trouble using should() with chai -- can't seem to import it? Could you add to the doc? Also, if we want to globally initialize chai.should(), where should the code go?

[shaunc]

Aha ... putting into test-helper.js works:

 // Declare `expect` as a global here instead of as a var in individual tests.
 // This avoids jshint warnings re: `Redefinition of 'expect'`.
 window.expect = chai.expect;
 window.should = chai.should();

[dgeb]

Glad you sorted it. Did you mean window.should = chai.should; instead of window.should = chai.should(); ?

Because the blueprints all use expect, I'm on the fence as to whether to include this declaration for everyone or just provide instructions in the README.

[shaunc]

chai.should needs to be called once globally in order to inject "should" into Object.proto. Having this available doesn't preclude the use of expect, of course. This would seem like the place to do it. Of course you could split the difference and just have it available. (Perhaps there is some test so test code could include something such as:

if (typeof should === 'function') window.should = should();

in all their tests.) I at least haven't hit any drawbacks or collisions with having .should everywhere. In the best case, availability of should would be configurable somehow. Is EmberENV available here?

[shaunc]

btw also using sinon -- found http://knomedia.github.io/blog/2014/05/31/using-ember-cli-and-sinon/ helpful for install, but is a bit of a winding path. Could there be blueprints for "install some (arbitrary) test package"?

[tonycoco]

@shaunc you could also use: https://github.com/csantero/ember-sinon

[jonathanKingston]

👍 to exposing Chai internals in each test (which seems to be the way ember-cli is suggesting to write qunit tests).

Personally for me assert has the most sane syntax as for BDD code a real BDD assertion library should be used external to these tests where by business can drive the tests like cucumber.

So I would like to be able to do:

import { assert } from 'ember-mocha';

Or similar.

[dgeb]

So, we've just introduced a chai module in ember-mocha that exports expect and assert. Both @rwjblue and I were wary to export should alongside these two, as discussed here: #37 (comment)

To semi-officially support should, we could just add a suggestion to the README to add window.chai.should(); to test-helper.js. Of course accessing a global like this is pretty hackish when everything else is modularized.

We could also export should through a new shim module in ember-mocha (perhaps chai-should?). If anyone really wants this, let's have the discussion here or in ember-mocha. Of course, such a shim could be added to a completely separate lib even if we decide against including it in ember-mocha.

[Turbo87]

This should be covered by ember-cli-chai now.