Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Ember 3.20 #164

Closed
boris-petrov opened this issue Jul 13, 2020 · 7 comments
Closed

Deprecation warning with Ember 3.20 #164

boris-petrov opened this issue Jul 13, 2020 · 7 comments

Comments

@boris-petrov
Copy link
Contributor

Starting with Ember 3.20, the following warning appears in the console:

DEPRECATION: The use of the private `{{-in-element}}` is deprecated, please refactor to the public `{{in-element}}`. ('ember-cli-head/templates/components/head-layout.hbs' @ L1:C0)  [deprecation id: glimmer.private-in-element]

This is because ember-page-title uses ember-cli-head 0.4.0 which uses the private -in-element. Version 1.0.0 has this issue resolved so a simple bump of the version should suffice to fix this.

@knownasilya
Copy link
Contributor

Should be resolved by #162

@knownasilya
Copy link
Contributor

Will be released this week

@raido
Copy link
Contributor

raido commented Aug 21, 2020

@knownasilya any updates on the release?

@knownasilya
Copy link
Contributor

So there's an ongoing effort to make page-title the official title addon that is included with a new app setup (see #167) and that would also need a breaking change, so the major release has been delayed a bit. If you need it, feel free to use the latest sha "ember-page-title": "adopted-ember-addons/ember-page-title#4f249a9" or fork to your own account and do the same, at least until we release the next major version.

@raido
Copy link
Contributor

raido commented Aug 21, 2020

What are main blockers? Or just not enough free cycles to open PR for this change?

@knownasilya
Copy link
Contributor

I haven't had time to dig in yet, but feel free to if you have time this week.

@knownasilya
Copy link
Contributor

Resolved with #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants