-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide getPageTitle test helper to consuming apps #209
Conversation
test: update tests to use exported get-page-title test helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doc updates, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated
@raido thoughts on this addition? Since the helper was internal only before. |
I'll clarify that part of our enterprise front-end is waiting on this PR to get merged. We had previously run our acceptance tests via a private helper as well, but this quickly became cumbersome when we needed to assert page titles on addon acceptance tests. |
@knownasilya, can we also bump |
Done |
I am a bit late here, but since this "private" helper is re-exported via index.js, it's fine. We can easily re-work internals. We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice. This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper. The |
This PR allows consuming apps to assert a page's
title
(whether integration or acceptance test).Usage documented in the
README.md
: