Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html should be imported from @ember/string instead #56

Closed
jakevo opened this issue May 21, 2018 · 2 comments
Closed

html should be imported from @ember/string instead #56

jakevo opened this issue May 21, 2018 · 2 comments

Comments

@jakevo
Copy link

jakevo commented May 21, 2018

As title, I think htmlSafe should be imported from ember/string instead of ember/template according to
https://emberjs.com/api/ember/release/modules/@ember%2Fstring

@jamesarosen
Copy link

See also emberjs/rfcs#236 and ember-codemods/ember-modules-codemod#85. @rwjblue says @ember/template is the correct location, but it doesn't work on any of the versions of ember we use.

@Turbo87
Copy link
Member

Turbo87 commented Oct 10, 2018

you need to make sure that you have the most recent ember-rfc176-data version in your node_modules. e.g. if you use a yarn or npm lockfile you might still have an older one which still assumed it to be at @ember/string

@Turbo87 Turbo87 closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants