Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that changes landed in Ember do not fail no-replace-test-comments #765

Closed
rwjblue opened this issue Apr 10, 2020 · 0 comments · Fixed by #766
Closed

Verify that changes landed in Ember do not fail no-replace-test-comments #765

rwjblue opened this issue Apr 10, 2020 · 0 comments · Fixed by #766

Comments

@rwjblue
Copy link
Member

rwjblue commented Apr 10, 2020

The changes here: emberjs/ember.js#18828 prepend TODO: to the generated linting tests.

I just wanted to make sure that those changes won't break the no-replace-test-comments rule.

cc @jaydgruber
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for no-replace-test-comments rule with TODO-prefixed comment
1 participant
@rwjblue