Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit-injections deprecation is missing for v4.x series #1065

Closed
SergeAstapov opened this issue Jan 18, 2022 · 2 comments
Closed

implicit-injections deprecation is missing for v4.x series #1065

SergeAstapov opened this issue Jan 18, 2022 · 2 comments

Comments

@SergeAstapov
Copy link

DEPRECATION: As of Ember 4.0.0, owner.inject no longer injects values into resolved instances, and calling the method has been deprecated. Since this method no longer does anything, it is fully safe to remove this injection. As an alternative to this API, you can refactor to explicitly inject _ajaxRequest on adapter, or look it up directly using the getOwner API. [deprecation id: remove-owner-inject] See https://deprecations.emberjs.com/v4.x#toc_implicit-injections for more details.

More some background, see ember-fastboot/ember-cli-fastboot#869

@jaredgalanis
Copy link
Member

@SergeAstapov 👍 I think there is a PR for this but it's been open for quite a while. I'll ping the author/reviewer now.

#932

DEPRECATION: As of Ember 4.0.0, owner.inject no longer injects values into resolved instances, and calling the method has been deprecated. Since this method no longer does anything, it is fully safe to remove this injection. As an alternative to this API, you can refactor to explicitly inject _ajaxRequest on adapter, or look it up directly using the getOwner API. [deprecation id: remove-owner-inject] See https://deprecations.emberjs.com/v4.x#toc_implicit-injections for more details.

More some background, see ember-fastboot/ember-cli-fastboot#869

@locks
Copy link
Contributor

locks commented May 28, 2022

Relevant PR has been merged!

@locks locks closed this as completed May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants