Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text for Ember.String namespace deprecation is incomplete #686

Closed
chriskrycho opened this issue Oct 15, 2020 · 5 comments · Fixed by #687
Closed

Text for Ember.String namespace deprecation is incomplete #686

chriskrycho opened this issue Oct 15, 2020 · 5 comments · Fixed by #687
Labels
good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest

Comments

@chriskrycho
Copy link
Contributor

The Ember.String namespace deprecation reads, in part:

Starting with Ember v2.18.0 [TODO: update to proper version], the @ember/string package was extracted from the Ember codebase into a separate module.

Note the [TODO: update to proper version]! If someone can inform me of the actual version, I'm happy to submit a PR to fix it. 😅
@jaredgalanis
Copy link
Member

jaredgalanis commented Oct 15, 2020 •
edited
Loading

Thanks for finding this @chriskrycho!

To me, it looks like it was extracted here: emberjs/ember.js#16530 and came in at v3.3.0.

@jaredgalanis jaredgalanis added good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest labels Oct 16, 2020
@jaredgalanis
Copy link
Member

Possible duplicate of #322

@JamesS-M
Copy link
Contributor

I'm working on this!

@JamesS-M JamesS-M mentioned this issue Oct 16, 2020
Merged
@jaredgalanis
Copy link
Member

jaredgalanis commented Oct 16, 2020 •
edited
Loading

@chriskrycho we discussed this with @locks and for now we're actually just going to remove the deprecations until this work has progressed further.

@chriskrycho
Copy link
Contributor Author

That seems totally reasonable. Thanks for the quick follow-through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove ember string namespace JamesS-M/deprecation-app
3 participants
@chriskrycho @jaredgalanis @JamesS-M