Skip to content

Commit df179e2

Browse files
committed
Restore tests that were skipped as part of the redesign
1 parent af5ccc0 commit df179e2

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

app/components/table-of-contents.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<label class='toc-private-toggle'>
2-
<input type='checkbox' checked={{@showPrivateClasses}} onchange={{@togglePrivateClasses}} class='private-deprecated-toggle' />
2+
<input type='checkbox' checked={{@showPrivateClasses}} onchange={{@togglePrivateClasses}} class='private-deprecated-toggle' data-test-private-deprecated-toggle />
33
Show Private / Deprecated packages
44
</label>
55
<ul class='table-of-contents '>

tests/acceptance/function-test.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
11
/* eslint-disable qunit/no-assert-equal */
22
import { module, test } from 'qunit';
33
import { setupApplicationTest } from 'ember-qunit';
4-
import { visit, find } from '@ember/test-helpers';
4+
import { visit } from '@ember/test-helpers';
55

66
module('Acceptance | Function', function (hooks) {
77
setupApplicationTest(hooks);
88

9-
test.skip('shows function when loaded from url', async function (assert) {
9+
test('shows function when loaded from url', async function (assert) {
1010
await visit('ember/2.18/functions/@ember%2Fapplication/getOwner');
1111

1212
assert.dom('.method').exists({ count: 1 }, 'Single function per page');
13-
assert.equal(
14-
find('.method .method-name').innerText,
15-
'getOwner',
16-
'Correct function is shown',
17-
);
13+
assert.dom('.method .method-name').hasText('getOwner');
1814
});
1915

2016
test('shows function when loaded from url in a more modern version', async function (assert) {

tests/acceptance/module-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/* eslint-disable qunit/no-assert-equal */
2-
import { module, test, skip } from 'qunit';
2+
import { module, test } from 'qunit';
33
import { setupApplicationTest } from 'ember-qunit';
44
import { visit, click, findAll } from '@ember/test-helpers';
55

66
module('Acceptance | Module', function (hooks) {
77
setupApplicationTest(hooks);
88

9-
skip('lists all public/private classes and namespaces on the module page', async function (assert) {
9+
test('lists all public/private classes and namespaces on the module page', async function (assert) {
1010
await visit('ember/1.0/modules/ember-handlebars');
1111

1212
const store = this.owner.lookup('service:store');
@@ -28,7 +28,7 @@ module('Acceptance | Module', function (hooks) {
2828
numberPublicClasses + numberNameSpaces,
2929
);
3030

31-
await click('.sidebar .private-deprecated-toggle');
31+
await click('[data-test-private-deprecated-toggle]');
3232
assert.equal(
3333
findAll('.spec-property-list li').length,
3434
numberPublicClasses + numberNameSpaces + numberPrivateClasses,

tests/acceptance/switch-versions-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ module('Acceptance | version navigation', function (hooks) {
165165
);
166166
});
167167

168-
test.skip('switching versions works if class name includes slashes', async function (assert) {
168+
test('switching versions works if class name includes slashes', async function (assert) {
169169
await visit('/ember/3.4/classes/@ember%2Fobject%2Fcomputed');
170170
assert.equal(
171171
currentURL(),
@@ -197,7 +197,7 @@ module('Acceptance | version navigation', function (hooks) {
197197
);
198198
});
199199

200-
test.skip(`switching versions works if we've previously switched for a different class`, async function (assert) {
200+
test(`switching versions works if we've previously switched for a different class`, async function (assert) {
201201
await visit('/ember/3.4/classes/@ember%2Fobject%2Fcomputed');
202202
assert.equal(
203203
currentURL(),

0 commit comments

Comments
 (0)