Skip to content

Commit e8499ed

Browse files
authored
Merge pull request #944 from ember-learn/is-visible
fix ember-component.is-visible deprecation
2 parents d885c0f + 7b7705a commit e8499ed

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

app/components/search-input.hbs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
@class='ds-dropdown-results'
2020
>
2121
<SearchInput::Dropdown
22-
@isVisible={{this._focused}}
2322
@results={{this.searchService.results}}
2423
@noResults={{if
2524
(and

app/components/search-input/dropdown.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ export default class Dropdown extends Component {
1414
// Public API
1515
role = 'listbox';
1616

17-
isVisible = false;
18-
1917
// show
2018
// Massage data to make it easier for displaying on the template
2119
// Returned object:

app/deprecation-workflow.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ setupDeprecationWorkflow({
66
{ handler: 'throw', matchId: 'ember.component.reopen' },
77
{ handler: 'throw', matchId: 'implicit-injections' },
88
{ handler: 'silence', matchId: 'this-property-fallback' },
9-
{ handler: 'silence', matchId: 'ember-component.is-visible' },
9+
{ handler: 'throw', matchId: 'ember-component.is-visible' },
1010
{
1111
handler: 'silence',
1212
matchId: 'deprecated-run-loop-and-computed-dot-access',

0 commit comments

Comments
 (0)