Skip to content

Commit 191d51b

Browse files
authored
fix compatibility with ember-data 5 (#1517)
1 parent 5c7eb86 commit 191d51b

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

.github/workflows/ci-cd.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ jobs:
9898
try-scenario:
9999
- 'ember-lts-4.4'
100100
- 'ember-lts-4.8'
101+
- 'ember-lts-5.4'
101102
- 'ember-release'
102103
- 'ember-beta'
103104
- 'ember-canary'

addon/models/class.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { filterBy, or, union } from '@ember/object/computed';
33
import { memberUnion, hasMemberType } from '../utils/computed';
44

55
export default class Class extends Model {
6-
@belongsTo('class', { async: false, inverse: null })
6+
@belongsTo('class', { async: false, inverse: null, polymorphic: false })
77
parentClass;
88

99
isClass = true;

addon/models/module.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ export default class Module extends Model {
1010
@attr
1111
functions;
1212

13-
@hasMany('class', { async: false, inverse: null })
13+
@hasMany('class', { async: false, inverse: null, polymorphic: true })
1414
classes;
1515

16-
@hasMany('class', { async: false, inverse: null })
16+
@hasMany('class', { async: false, inverse: null, polymorphic: true })
1717
components;
1818

1919
/*

addon/models/project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ export default class Project extends Model {
1313
@attr
1414
navigationIndex;
1515

16-
@hasMany('module', { async: false, inverse: null })
16+
@hasMany('module', { async: false, inverse: null, polymorphic: false })
1717
modules;
1818
}

tests/dummy/config/ember-try.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,15 @@ module.exports = async function () {
2323
},
2424
},
2525
},
26+
{
27+
name: 'ember-lts-5.4',
28+
npm: {
29+
devDependencies: {
30+
'ember-data': '~5.3.0',
31+
'ember-source': '~5.4.0',
32+
},
33+
},
34+
},
2635
{
2736
name: 'ember-release',
2837
npm: {

0 commit comments

Comments
 (0)