Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember deploy production doesn't work with GHE #323

Open
mehulkar opened this issue Feb 16, 2019 · 3 comments
Open

ember deploy production doesn't work with GHE #323

mehulkar opened this issue Feb 16, 2019 · 3 comments

Comments

@mehulkar
Copy link

I wasn't able to run ember deploy production when my repository is set to a Github Enterprise URL. I traced it down to the hosted-git-info, and I think it's becuase it defines a set of known github instances and doesn't recognize anything else:

https://github.com/npm/hosted-git-info/blob/latest/git-host-info.js

@mehulkar
Copy link
Author

Looks like it's something out of scope for that particular module:

npm/hosted-git-info#11 (comment)

@dcyriller
Copy link
Contributor

I face the same issue with Gitlab Entrerprise. There is this workaround where I tweak https://github.com/ember-learn/ember-cli-addon-docs/blob/master/lib/deploy/plugin.js#L184. But how could we provide a more permanent solution? 🤔 I'm ready to work on this.

@dcyriller
Copy link
Contributor

dcyriller commented Mar 26, 2019

Ok, good news is: it's supported through a bit of ember-cli-deploy-git config.
In your addon's config/deploy.js, you'll want to add this line:

ENV.git = { repo: `git@gitlab.${custom-domain}:${orga-name}/${project-name}.git' }

I'll open a PR to update the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants