Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Octane guides section - Components: Using Block Params #441

Closed
2 tasks
locks opened this issue Feb 13, 2019 · 5 comments
Closed
2 tasks

Update Octane guides section - Components: Using Block Params #441

locks opened this issue Feb 13, 2019 · 5 comments
Labels
help wanted Extra attention is needed Octane

Comments

@locks
Copy link
Contributor

locks commented Feb 13, 2019

Your PR should target the octane branch.

Goal

Update the "Using Block Params" sub-section of the Octane guides so it is consistent with the Octane edition of Ember.

TODO

  • Update code samples to native class and decorators
  • Update code sample paths to Octane layout paths
@locks locks added the Octane label Feb 13, 2019
@locks locks added the help wanted Extra attention is needed label Feb 13, 2019
@locks locks mentioned this issue Feb 13, 2019
Closed
2 tasks
@gossi
Copy link

gossi commented Feb 13, 2019

Do you trap yourself? #328

@locks
Copy link
Contributor Author

locks commented Feb 13, 2019

@gossi I don't understand your question 🤔

@gossi
Copy link

gossi commented Feb 20, 2019

Because you created another ticket just like this one. I don't understand why.

@locks
Copy link
Contributor Author

locks commented Feb 20, 2019

#328 is to document has-block-params, this one is for the Octane preview Guides effort.

@jenweber
Copy link
Contributor

Closed by work in https://github.com/ember-learn/guides-source/blob/octane/guides/release/components/wrapping-content-in-a-component.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Octane
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@locks @gossi @jenweber