Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the super rentals app to the Octane preview #118

Closed
jenweber opened this issue Mar 20, 2019 · 5 comments
Closed

Convert the super rentals app to the Octane preview #118

jenweber opened this issue Mar 20, 2019 · 5 comments
Assignees

Comments

@jenweber
Copy link
Contributor

I chatted with @vaidehijoshi who is interested to help with this!

@vaidehijoshi
Copy link

@jenweber feel free to assign me to this (looks like i don't actually have the permissions to do that). i'll get started on it in the next week or two once i recover from emberconf 😅

@jenweber
Copy link
Contributor Author

jenweber commented May 9, 2019

Hi @vaidehijoshi, just pinged you on Discord as well, but in case you don't check it much, is this issue something you still want to work on? Do you think you could have a PR in the next week or so? Let me know. Thanks!

@vaidehijoshi
Copy link

@jenweber Hi Jen! I actually just started working on this issue earlier this week and started my own branch for it. But I've been pretty sick the past day or two and haven't been able to work on it since then. 😕 I am still interested and can try to get it done in another week or two? I got a little stuck on it (somehow I broke all the CSS but haven't investigated why/how) when I started upgrading earlier this week, but hopefully I can figure it out once I feel well enough to work on it again.

@vaidehijoshi
Copy link

Update: I have a WIP for this (see #123)!

@jenweber
Copy link
Contributor Author

jenweber commented Jul 1, 2019

Thank you!

@jenweber jenweber closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants