Skip to content

Commit b5557ea

Browse files
authored
chore(types): split out lint and type commands to be per-package (#9032)
* stash * stash progress on lint and tsc split out * cleanup * more cleanup * attempt to fix deps * get more things working * more lockfile cleanup * things * fix builds * fix test * port turbo work * small tweaks * fix boolean * decycle * fix another cycle * build * fix build * more improvements * fix main tests * more fixups * remove some dead stuff * remove unused pnpm peer ignores * cleanup test commands * more task cleanup * fixup some tests * some turbo cleanup * more command cleanup * make tests nicer? * fix fastboot tests * gets it all working * test:production * fix test:production * fixup some test runs * skip adapter prod * more test fixes for prod
1 parent 6da2c77 commit b5557ea

File tree

333 files changed

+8297
-4859
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

333 files changed

+8297
-4859
lines changed

.eslintrc.js ._eslintrc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ module.exports = {
100100
env: {
101101
browser: true,
102102
node: false,
103-
es6: true,
103+
es2022: true,
104104
},
105105
overrides: [
106106
{

.eslintignore

-54
This file was deleted.

.github/actions/setup/action.yml

+6
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ runs:
5757
with:
5858
bun-version: latest
5959

60+
- name: 'Setup local TurboRepo server'
61+
if: ${{ inputs.repo-token }}
62+
uses: felixmosh/turborepo-gh-artifacts@v2
63+
with:
64+
repo-token: ${{ inputs.repo-token }}
65+
6066
- name: Configure Parallel Builds
6167
if: ${{ inputs.parallel-build == 'true' }}
6268
shell: bash

.github/workflows/alpha-release.yml

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ on:
66
- cron: '0 20 * * 2' # weekly (Tuesday) 12 PM PST
77
- cron: '0 20 * * 5' # weekly (Friday) 12 PM PST
88

9+
env:
10+
TURBO_API: http://127.0.0.1:9080
11+
TURBO_TOKEN: this-is-not-a-secret
12+
TURBO_TEAM: myself
13+
914
jobs:
1015
release:
1116
name: Run publish script
@@ -26,6 +31,7 @@ jobs:
2631
- uses: ./.github/actions/setup
2732
with:
2833
install: true
34+
repo-token: ${{ secrets.GITHUB_TOKEN }}
2935
- name: Make sure git user is setup
3036
run: |
3137
git config --local user.email 'tomster@emberjs.com'

.github/workflows/asset-size-check.yml

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- synchronize
1010
- ready_for_review
1111

12+
env:
13+
TURBO_API: http://127.0.0.1:9080
14+
TURBO_TOKEN: this-is-not-a-secret
15+
TURBO_TEAM: myself
16+
1217
concurrency:
1318
group: asset-size-${{ github.head_ref || github.ref_name }}
1419
cancel-in-progress: true

.github/workflows/beta-release.yml

+6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ name: Canary-Mirror-Beta Release
33
on:
44
workflow_dispatch:
55

6+
env:
7+
TURBO_API: http://127.0.0.1:9080
8+
TURBO_TOKEN: this-is-not-a-secret
9+
TURBO_TEAM: myself
10+
611
jobs:
712
release:
813
name: Run publish script
@@ -25,6 +30,7 @@ jobs:
2530
with:
2631
build-addons: true
2732
install: true
33+
repo-token: ${{ secrets.GITHUB_TOKEN }}
2834
- name: Make sure git user is setup
2935
run: |
3036
git config --local user.email 'tomster@emberjs.com'

.github/workflows/compat-tests.yml

+10
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ on:
55
branches:
66
- main
77

8+
env:
9+
TURBO_API: http://127.0.0.1:9080
10+
TURBO_TOKEN: this-is-not-a-secret
11+
TURBO_TEAM: myself
12+
813
concurrency:
914
group: compat-${{ github.head_ref || github.ref_name }}
1015
cancel-in-progress: true
@@ -19,6 +24,7 @@ jobs:
1924
with:
2025
restore-broccoli-cache: true
2126
install: true
27+
repo-token: ${{ secrets.GITHUB_TOKEN }}
2228
- name: Run Tests
2329
run: pnpm test:fastboot
2430
embroider:
@@ -30,6 +36,7 @@ jobs:
3036
with:
3137
restore-broccoli-cache: true
3238
install: true
39+
repo-token: ${{ secrets.GITHUB_TOKEN }}
3340
- name: Run Tests
3441
run: pnpm test:embroider
3542
env:
@@ -40,6 +47,8 @@ jobs:
4047
steps:
4148
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
4249
- uses: ./.github/actions/setup
50+
with:
51+
repo-token: ${{ secrets.GITHUB_TOKEN }}
4352
- name: Install dependencies w/o lockfile
4453
run: pnpm install --no-lockfile
4554
- name: Basic Tests
@@ -58,5 +67,6 @@ jobs:
5867
node-version: ${{ matrix.node-version }}
5968
restore-broccoli-cache: true
6069
install: true
70+
repo-token: ${{ secrets.GITHUB_TOKEN }}
6171
- name: Basic Tests
6272
run: pnpm test

.github/workflows/deprecations-check.yml

+5
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ name: 'Check Deprecations'
33
on:
44
workflow_dispatch:
55

6+
env:
7+
TURBO_API: http://127.0.0.1:9080
8+
TURBO_TOKEN: this-is-not-a-secret
9+
TURBO_TEAM: myself
10+
611
jobs:
712
test-all-deprecations:
813
runs-on: ubuntu-latest

.github/workflows/docs-and-blueprint-tests.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ on:
55
branches:
66
- main
77

8+
env:
9+
TURBO_API: http://127.0.0.1:9080
10+
TURBO_TOKEN: this-is-not-a-secret
11+
TURBO_TEAM: myself
12+
813
concurrency:
914
group: docs-${{ github.head_ref || github.ref_name }}
1015
cancel-in-progress: true
@@ -18,7 +23,8 @@ jobs:
1823
- uses: ./.github/actions/setup
1924
with:
2025
install: true
26+
repo-token: ${{ secrets.GITHUB_TOKEN }}
2127
- name: Test Docs
2228
run: pnpm test:docs
2329
- name: Test Blueprints
24-
run: pnpm --filter blueprint-tests run test
30+
run: pnpm test:blueprints

.github/workflows/infra-tests.yml

+6
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- synchronize
1010
- ready_for_review
1111

12+
env:
13+
TURBO_API: http://127.0.0.1:9080
14+
TURBO_TOKEN: this-is-not-a-secret
15+
TURBO_TEAM: myself
16+
1217
concurrency:
1318
group: infra-${{ github.head_ref || github.ref_name }}
1419
cancel-in-progress: true
@@ -24,6 +29,7 @@ jobs:
2429
with:
2530
restore-broccoli-cache: true
2631
install: true
32+
repo-token: ${{ secrets.GITHUB_TOKEN }}
2733
- name: pnpm test infra compatWith 3.0
2834
env:
2935
COMPAT_WITH: '3.0'

.github/workflows/main.yml

+14-4
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ on:
1212
tags:
1313
- '*'
1414

15+
env:
16+
TURBO_API: http://127.0.0.1:9080
17+
TURBO_TOKEN: this-is-not-a-secret
18+
TURBO_TEAM: myself
19+
1520
concurrency:
1621
group: ci-${{ github.head_ref || github.ref_name }}
1722
cancel-in-progress: true
@@ -26,10 +31,11 @@ jobs:
2631
with:
2732
restore-lint-caches: true
2833
install: true
29-
- name: Lint js
30-
run: pnpm lint:js
31-
- name: Check for TypeScript problems
32-
run: pnpm problems
34+
repo-token: ${{ secrets.GITHUB_TOKEN }}
35+
- name: Lint
36+
run: pnpm lint
37+
- name: Check Uncompiled Packages for TypeScript Compilation Errors
38+
run: pnpm check:types
3339

3440
special-build-tests:
3541
timeout-minutes: 20
@@ -40,6 +46,7 @@ jobs:
4046
with:
4147
restore-broccoli-cache: true
4248
install: true
49+
repo-token: ${{ secrets.GITHUB_TOKEN }}
4350
- if: |
4451
github.event_name == 'pull_request' && (
4552
github.base_ref == 'main' || github.base_ref == 'beta'
@@ -82,6 +89,7 @@ jobs:
8289
jobs: 2
8390
parallel-build: true
8491
install: true
92+
repo-token: ${{ secrets.GITHUB_TOKEN }}
8593

8694
- name: Check for Test Failure Retry
8795
id: retry-test-failures
@@ -147,6 +155,7 @@ jobs:
147155
with:
148156
restore-broccoli-cache: true
149157
install: true
158+
repo-token: ${{ secrets.GITHUB_TOKEN }}
150159
- name: Basic tests with ${{ matrix.scenario }}
151160
timeout-minutes: 12
152161
env:
@@ -173,6 +182,7 @@ jobs:
173182
with:
174183
restore-broccoli-cache: true
175184
install: true
185+
repo-token: ${{ secrets.GITHUB_TOKEN }}
176186
- name: Basic tests with ${{ matrix.release }}
177187
env:
178188
CI: true

.github/workflows/partner-tests.yml

+6
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- synchronize
1010
- ready_for_review
1111

12+
env:
13+
TURBO_API: http://127.0.0.1:9080
14+
TURBO_TOKEN: this-is-not-a-secret
15+
TURBO_TEAM: myself
16+
1217
concurrency:
1318
group: partners-${{ github.head_ref || github.ref_name }}
1419
cancel-in-progress: true
@@ -54,6 +59,7 @@ jobs:
5459
restore-broccoli-cache: true
5560
install: true
5661
build-addons: true
62+
repo-token: ${{ secrets.GITHUB_TOKEN }}
5763
- name: Generate package tarballs
5864
run: node ./scripts/packages-for-commit.js
5965
- name: Run Tests

.github/workflows/perf-check.yml

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- synchronize
1010
- ready_for_review
1111

12+
env:
13+
TURBO_API: http://127.0.0.1:9080
14+
TURBO_TOKEN: this-is-not-a-secret
15+
TURBO_TEAM: myself
16+
1217
concurrency:
1318
group: perf-${{ github.head_ref || github.ref_name }}
1419
cancel-in-progress: true

.github/workflows/perf-over-release.yml

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ on:
99
- synchronize
1010
- ready_for_review
1111

12+
env:
13+
TURBO_API: http://127.0.0.1:9080
14+
TURBO_TOKEN: this-is-not-a-secret
15+
TURBO_TEAM: myself
16+
1217
concurrency:
1318
group: perf-release-${{ github.head_ref || github.ref_name }}
1419
cancel-in-progress: true

.gitignore

+4-3
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,19 @@ packages/rest/addon
2222
packages/active-record/addon
2323
packages/data-worker/addon
2424
packages/schema-record/addon/
25-
packages/core/addon/
25+
packages/core-types/addon
2626

2727
# dependencies
2828
bower_components
2929
node_modules
3030
scripts/asset-size-tracking/current-data.json
3131

3232
# misc
33+
.turbo/
3334
.env*
3435
.pnp*
3536
.sass-cache
36-
/.eslintcache
37+
.eslintcache
3738
/onnect.lock
3839
coverage/*
3940
libpeerconnection.log
@@ -65,6 +66,6 @@ benchmarks/results/*.json
6566
/packages/*/DEBUG
6667
/tests/*/DEBUG
6768

68-
.vscode/
69+
!.vscode/
6970
.idea/
7071
*.iml

.prettierrc

-3
This file was deleted.

.prettierrc.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = {
2+
singleQuote: true,
3+
trailingComma: 'es5',
4+
printWidth: 120
5+
}

.vscode/settings.json

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"files.associations": {
3+
"turbo.json": "jsonc"
4+
}
5+
}

@types/ember-data-qunit-asserts/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { CacheOperation, NotificationType } from "@ember-data/store/-private/managers/notification-manager";
22
import type { StableDocumentIdentifier } from "@ember-data/store/-types/cache/identifier";
3-
import type { StableRecordIdentifier } from "@warp-drive/core";
3+
import type { StableRecordIdentifier } from "@warp-drive/core-types";
44

55
declare global {
66
interface DeprecationConfig {

@types/ember/index.d.ts

-1
This file was deleted.

0 commit comments

Comments
 (0)