Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queryRecord #3261

Closed
bmac opened this issue Jun 8, 2015 · 4 comments
Closed

Implement queryRecord #3261

bmac opened this issue Jun 8, 2015 · 4 comments

Comments

@bmac
Copy link
Member

bmac commented Jun 8, 2015

@thaume Any chance you have time to implement this one?

  /**
   `queryRecord` asks the adapter to fetch a single record using a query object.

   This method is asynchronous.

   @method queryRecord
   @param {String} type
   @param {Object} query
   @param {Object} options
   @return {DS.PromiseObject} record
   */
  queryRecord: function(type, query, options),
@HeroicEric
Copy link
Member

If this is going to be added, would it be more consistent to have store.query be named store.queryAll?

@thaume
Copy link

thaume commented Jun 10, 2015

@bmac I'm working on it over here https://github.com/emberjs/data/pull/2584/files

@bmac
Copy link
Member Author

bmac commented Jun 10, 2015

There was some talk about using queryAll for consistency with the findAll and peekAll however it was decided to stay with query because the records returned from the server by a query are likely a subset of all the record.

@bmac
Copy link
Member Author

bmac commented Jun 16, 2015

Closed by #2584

@bmac bmac closed this as completed Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants