Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find module ember-data/-private #5163

Closed
royk opened this issue Sep 6, 2017 · 9 comments
Closed

Could not find module ember-data/-private #5163

royk opened this issue Sep 6, 2017 · 9 comments

Comments

@royk
Copy link

royk commented Sep 6, 2017

This issue was reported and fixed in #5021
With the latest release of Ember Data it (2.15.0) it happens again. Reverting to 2.14.10 fixes it.
This is my console output when running ember test:

---
        actual: >
            null
        expected: >
            null
        stack: >
            http://localhost:7357/assets/test-support.js:5296
        message: >
            Error: 
            Error: Could not find module `ember-data/-private` imported from `ember-data/setup-container`
            TypeError: undefined is not an object (evaluating 'initializer.name')
            TypeError: undefined is not an object (evaluating 'initializer.name')
        Log: |
    ...
@Turbo87
Copy link
Member

Turbo87 commented Sep 7, 2017

/cc @rwjblue @stefanpenner @bmac

@urbany
Copy link

urbany commented Sep 7, 2017

Isn't this a duplicate of #5019 ?

@Turbo87
Copy link
Member

Turbo87 commented Sep 7, 2017

@urbany #5021 and #5019 were about v2.14.x, and according to #5021 the issue was fixed in v2.14.10. This issue here is about v2.15.x which apparently reintroduced the same problem again...

@urbany
Copy link

urbany commented Sep 7, 2017

Ah got it, thanks! Maybe #5019 can be closed then.

@krisselden
Copy link
Contributor

#5022 fixed the original issue reported (#5019), but it targeted 2.14's release branch and was not ported forward to beta or master branch.

@rwjblue - Would you mind submitting PR's updating the other branches?

@rwjblue
Copy link
Member

rwjblue commented Sep 29, 2017

Further sluething shows it was ported to master in #5031 a few months ago (and is therefore in the current beta branch). It was not ported to the beta branch at the time (which was then promoted to release for 2.15) and hence has resurfaced...

@bmac
Copy link
Member

bmac commented Sep 29, 2017

Hi @krisselden thanks for calling this out. It looks like @stefanpenner
ported this to master in pr #5031 so its on the current master and beta branches. However its missing form the current release branch. I just opened a pr to add to to release #5195. I can merge and release it later today.

@rwjblue
Copy link
Member

rwjblue commented Sep 29, 2017

@bmac ❤️

@bmac
Copy link
Member

bmac commented Sep 30, 2017

Release as Ember Data 2.15.3.

@bmac bmac closed this as completed Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants