Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUEST] documentation 2020: or tell a good story #6860

Closed
10 tasks
ghost opened this issue Dec 6, 2019 · 4 comments
Closed
10 tasks

[QUEST] documentation 2020: or tell a good story #6860

ghost opened this issue Dec 6, 2019 · 4 comments
Labels
🏷️ doc This PR adds/improves/or fixes documentation

Comments

@ghost
Copy link

ghost commented Dec 6, 2019

The ember-data core team and contributors would like to modernize the API documentation by EmberConf 2020. Modernizing entails writing a package overview, revising inline documentation and auditing code snippets for accuracy. I broke the sections of this quest issue out by logical aspects of ember-data's API. Each section will list individual tasks.

History repeats; everyone can help!

If you would like to climb the mountain with us claim a logical section of the API by commenting below. That section is yours, documentation-wise, for 48 hours. Let us know if you need more time, need clarity or run into problems trying to work through the task.

For questions, ideas, and other things do post in #dev-ember-data channel on Discord. Doing so enables us to triage effectively and incorporate those changes in a unified fashion to this QUEST issue. Defining a sensible contribution workflow is part of this quest as well. So we'd love to hear any rough edges and ideas for improvement. Fail forward, or so they say.

To preview your work locally follow the steps outlined in ember-jsonapi-docs.

Thank you for contributing!

transform

  • an overview introduction according to a common format. See the example format in the minimum serializer interface.
  • every public method and class is documented
  • provide examples of how to use each thing provided by the package
    1. Transform
    2. BooleanTransform
    3. DateTransform
    4. NumberTransform
    5. StringTransform
  • Update code snippet style
    1. native classes
    2. avoid var, prefer let
  • smoke test in a real ember application
@Gaurav0
Copy link
Contributor

Gaurav0 commented Dec 7, 2019

@efx We should link to the instructions on getting documentation running locally.

@Supot39
Copy link

Supot39 commented Feb 2, 2020

ต้องการเพียงแค่ทำเป็นเงินสกุลยาทไทยที่ใช้ได้ครับ..ต้องทำเช่นไร..แนะนำด้วยครับ..ผมไม่เก่งภาษาและระบบคอม...ค่าใช้จ่ายการเท่าไหร่หักไปเลยครับ...

@Angel-gc
Copy link

I'd like to grab the overview introduction (first bullet point)

@runspired
Copy link
Contributor

@Angel-gc that would be great! I just worked on some infra for the api docs app that will make this even nicer, happy to pair with you to get your setup running well locally to work on this.

@runspired runspired moved this to Quest | Planning in EmberData Feb 18, 2022
@runspired runspired unpinned this issue Aug 5, 2022
@ghost ghost closed this as completed Nov 15, 2022
Repository owner moved this from Quest | Planning to RFC | Needs Implemented in EmberData Nov 15, 2022
@runspired runspired added 🏷️ doc This PR adds/improves/or fixes documentation and removed Documentation labels Sep 11, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ doc This PR adds/improves/or fixes documentation
Projects
Archived in project
Development

No branches or pull requests

4 participants