Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: thread request context into identifiers merge function #6890

Closed
runspired opened this issue Dec 12, 2019 · 2 comments
Closed

chore: thread request context into identifiers merge function #6890

runspired opened this issue Dec 12, 2019 · 2 comments
Assignees
@runspired
Labels
🏷️ feat This PR introduces a new feature

Comments

@runspired
Copy link
Contributor

leaving myself a note for #6644 (comment)
@runspired runspired mentioned this issue Dec 12, 2019
Merged
@runspired runspired self-assigned this May 21, 2021
@runspired
Copy link
Contributor Author

We may want to update emberjs/rfcs#854 to have the MergeOperation receive the request context when available.

@runspired
Copy link
Contributor Author

So far we've been able to avoid needing this and with the current architecture where the cache has greater responsibility for plucking out resources this feels like it might even be the wrong thing to do. Closing in favor of a future RFC/RFC Issue should more context be needed for this use case.

@runspired runspired added 🏷️ feat This PR introduces a new feature and removed Improvement labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runspired runspired

Labels
🏷️ feat This PR introduces a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@runspired