Ember assert is not correctly transformed when using optional chaining

[mongoose700]

If I start with this code

import { assert } from '@ember/debug';

const foo = { bar: { baz: 'something' } };
assert('baz', foo.bar?.baz);

it gets transformed into

const foo = {
  bar: {
    baz: 'something'
  }
};
(true && !(_foo$bar.baz) && Ember.assert('baz', (_foo$bar = foo.bar) === null || _foo$bar === void 0 ? void 0 : _foo$bar.baz));

The first check for !(_foo$bar.baz) is performed before the (_foo$bar = foo.bar) assignment, which means it will always throw an error, regardless of the actual value.

[Techn1x]

We found this occurred specifically in our CI environment, when CI=true

[Techn1x]

Some starting points for investigation

CI flags look to be used here

ember-cli-babel/lib/ember-plugins.js

Line 12 in b61e71b

flags: { DEBUG: isDebug, CI: !!process.env.CI },

ember-cli-babel/lib/babel-options-util.js

Line 66 in b61e71b

flags: { DEBUG: isDebug, CI: !!process.env.CI },

From https://github.com/ember-cli/babel-plugin-debug-macros/tree/master

The assert macro can expand in a more intelligent way with the correct configuration. When babel-plugin-debug-macros is provided with the assertPredicateIndex the predicate is injected in front of the assertion in order to avoid costly assertion message generation when not needed.

And then;
https://github.com/ember-cli/babel-plugin-debug-macros/blob/f40c21bdd5d6332ae1862826ed9127317a1778a6/src/utils/builder.js#L14-L41

And;
https://github.com/ember-cli/babel-plugin-debug-macros/blob/f40c21bdd5d6332ae1862826ed9127317a1778a6/src/utils/builder.js#L110-L114

[Techn1x]

Looks like it has been reported over there as an issue
ember-cli/babel-plugin-debug-macros#89