Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestAnimationFrame cycle runs forever #12

Closed
mmun opened this issue Aug 18, 2015 · 1 comment
Closed

requestAnimationFrame cycle runs forever #12

mmun opened this issue Aug 18, 2015 · 1 comment
Labels
bug

Comments

@mmun
Copy link
Contributor

mmun commented Aug 18, 2015

Currently, the requestAnimationFrame cycle will never be broken. We should break the cycle (i.e. "cancel" the callback) in willDestroyElement.

See here: https://github.com/emberjs/ember-collection/blob/8bd9cc34304f26a7c2352e5e85db0731907555f5/addon/components/ember-collection.js#L125-L126.
@mmun mmun added the bug label Aug 18, 2015
@mmun mmun mentioned this issue Aug 18, 2015
Merged
@raytiley
Copy link
Contributor

working on this now.

@stefanpenner stefanpenner mentioned this issue Aug 18, 2015
Closed
raytiley added a commit to raytiley/ember-collection that referenced this issue Aug 18, 2015
@raytiley
Cancel animation frame when destroying component
d6d3654 
Fixes adopted-ember-addons#12. Still figuring out how to test this.
@raytiley raytiley mentioned this issue Aug 18, 2015
Merged
@mmun mmun closed this as completed in #16 Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raytiley @mmun