Tests 2.0 #1
Merged
Tests 2.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmun -- I followed your advice very literally: all tests outside of "content-test.js" skipped. (NB jshint still not passing -- many of the tests refer to entities that don't exist anymore... so will take a bit more time to clean that up if you need it.)
I removed the _super() call per your suggestion. I tried putting in an observer on items.[] rather than the dynamic array observer, but for some reason it broke "content-test" (the one suite that works!) -- so reverted. Your hand may be better than mine on this. I look forward to pulling. :)