Fix dummy app #13
Merged
Fix dummy app #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue related to the update to `layout-bin-packer`causing an `NaN` index when calculating the starting index. It invaldiates `cells` when rendering. This is needed to cause the cells to update during scrolling. Basically how this works now is `rAF` monitors the scroll position and if the positions change between frames it schedules a `rerender`. The `willRender` hook then invalidates the `cells` CP which ensures the correct items are rendered. Then glimmer takes over and renders the correct cells. I also guarded `contentElement` not being defined on initial render. Fix js hint
raytiley
force-pushed
the
fix-dummy-app
branch
from
7f7532c to
74d8779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue related to the update to
layout-bin-packercausingan
NaNindex when calculating the starting index. It invaldiatescellswhenrendering. This is needed to cause the cells to update during scrolling.
Basically how this works now is
rAFmonitors the scroll position andif the positions change between frames it schedules a
rerender. ThewillRenderhook then invalidates thecellsCP which ensures thecorrect items are rendered. Then glimmer takes over and renders the
correct cells.
I also guarded
contentElementnot being defined on initial render.