-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glimmer 2 Compatibility #130
Glimmer 2 Compatibility #130
Conversation
Some discussion: |
We're going to run this branch in production in Intercom as is for a little while. |
having some issues getting this working locally... |
if the blocker is glimmer support or not, maybe we should just bump a major version? |
It appears this doesn't work locally, that is likely something we must see to consider merge. |
#131 gets the dummy app started |
@lukemelia / @krisselden either of you guys some cycles to review. Dummy app seems to be functional |
@stefanpenner looks good to me. We'll need to get ember-try running tests for it. |
@lukemelia #131 does this I believe. |
merging this and then #131 |
For #126
Adding support for glimmer 2. Would appreciate any feedback on the approach.