Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer 2 Compatibility #130

Merged

Conversation

paddyobrien
Copy link
Contributor

For #126

Adding support for glimmer 2. Would appreciate any feedback on the approach.

@paddyobrien paddyobrien changed the title [WIP] Glimmer 2 Support Glimmer 2 Compatability Nov 2, 2016
@GavinJoyce
Copy link

GavinJoyce commented Nov 2, 2016

Some discussion:

screen shot 2016-11-02 at 20 36 01

screen shot 2016-11-02 at 20 36 11

screen shot 2016-11-02 at 20 41 29

@locks locks changed the title Glimmer 2 Compatability Glimmer 2 Compatibility Nov 2, 2016
@GavinJoyce
Copy link

We're going to run this branch in production in Intercom as is for a little while.

@stefanpenner
Copy link
Contributor

stefanpenner commented Nov 15, 2016

having some issues getting this working locally... ALthough CI seems to think its good. doesn't seem like CI does anything yet.

@stefanpenner
Copy link
Contributor

if the blocker is glimmer support or not, maybe we should just bump a major version?

@stefanpenner
Copy link
Contributor

having some issues getting this working locally.

It appears this doesn't work locally, that is likely something we must see to consider merge.

@stefanpenner
Copy link
Contributor

#131 gets the dummy app started

@stefanpenner
Copy link
Contributor

#131 gets the dummy app started

@lukemelia / @krisselden either of you guys some cycles to review. Dummy app seems to be functional

@lukemelia
Copy link
Collaborator

@stefanpenner looks good to me. We'll need to get ember-try running tests for it.

@stefanpenner
Copy link
Contributor

@lukemelia #131 does this I believe.

@stefanpenner
Copy link
Contributor

merging this and then #131

@stefanpenner stefanpenner merged commit 80b3739 into adopted-ember-addons:master Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants