Fix tests broken in browsers that have visible scrollbars #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the scrollbar calculation in the scroll top tests to work (at least on win browsers). The tests would always pass in OSX due to lack of scroll bars. The working tests highlighted some faulty logic in one of the tests where we were adding the size of a scroll bar to the height, even though there wasn't enough content to make a horizontal scroll bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the scrollbar calculation in the scroll top tests to work (at least on win browsers). The tests would always pass in OSX due to lack of scroll bars. The working tests highlighted some faulty logic in one of the tests where we were adding the size of a scroll bar to the height, even though there wasn't enough content to make a horizontal scroll bar.