Buffer fix

[shaunc]

Buffer should be added for both previous and next items, but only previous items were buffered.

[mmun]

Why did you add this?

[mmun]

Is there a way we can test the buffer without digging into state variables on the collection component? Specifically I'm talking about

var buffer = view.get('buffer') | 5;
var width = view.get('width') | 0;
var itemWidth = view.get('itemWidth') || 1;

I'm happy to merge as is if its not feasible, but I suspect it should be by analyzing the DOM?

cc @raytiley

[mmun]

Also, please rebase against master. In the ember projects we only merge master for long running branches.

[shaunc]

The real problem vs "digging into state" is that I'm doing a calculation that is really done by the layout, which I don't have access to. This could be done if sliceDidChange were available much more easily. The # of items in the dom is what I'm checking so I can't depend on DOM to get this info.

[mmun]

Gotcha.

[shaunc]

I'll rebase ... anything else for the moment? If/when "sliceDidChange" goes through & in order to write tests for mixedGrid these may want to be rewritten...

[mmun]

No, it's fine how it is other than the Ember.A() thing. You can leave a TODO comment about updating the tests later if you want.

[shaunc]

Ah -- didn't notice your Ember.A comment; sorry:

1. I did get an error earlier in a test that went away when I put Ember.A in init() (I think it was "pushObject not present). Perhaps I still had the package to turn off injections still installed, though it was removed from npm (or bower)?
2. In any case, I thought the guidance for Addons was that we should write without assuming that the ember stuff is injected. If so, the

  this._cells.pushObject(cell);

further down will break if you don't wrap in Ember.A.

[mmun]

Perhaps I still had the package to turn off injections still installed, though it was removed from npm (or bower)?

That's gotta be it.

Ember.A() is pretty dubious because it copies all the array extensions onto the array instance. If you want to avoid prototype extensions in your addon, the correct solution is not to copy all the extensions onto all your array instances, it is to not use prototype extensions :P

[mmun]

I think if you swap this._cells.pushObject with this._cells.push we can disable all prototype extensions again. We should do that separately though.

[shaunc]

Um... so should I put in a separate pull request to not use pushObject?

[shaunc]

ah -- just what I was thinking

[mmun]

:D I gotta run, I'll be back in a little while.

[shaunc]

Sure ... Should I create a new PR with pushObject -> push and https://github.com/rwjblue/ember-disable-prototype-extensions installed?

[mmun]

@shaunc Yes exactly. You might have to add Ember.A() in some tests but I doubt it.

[mmun]

@shaunc and remove this stuff too https://github.com/emberjs/ember-collection/blob/master/tests/dummy/config/environment.js#L9-L20

[shaunc]

@mmun -- ok -- I have rebased