Fix percentage-columns-layout #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a made a silly change that the tests didn't catch when first doing the percentage-columns-layout. This fixes that so the layout works properly. I also improved the tests so that it will catch it. The tests now check the top / left as well as the width property for the rendered items. While I was in the code I changed a design decision that was bothering me. Instead of having to pass an array with the same number of items as the content to the layout, you just need to pass the number of items. Finally I made the assert for the size of the columns more strict, since using a set of columns that were under 100 could cause the items to not fit into rows as desired. I fixed the tests that make sure we assert properly.
|
LGTM |
|
Does this fix the percentages demo? |
krisselden
added a commit
that referenced
this pull request
Feb 2, 2016
Fix percentage-columns-layout
|
Yes it does 👍 Edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a made a silly change that the tests didn't catch when first doing the percentage-columns-layout. This fixes that so the layout works properly. I also improved the tests so that it will catch it. The tests now check the top / left as well as the width property for the rendered items.
While I was in the code I changed a design decision that was bothering me. Instead of having to pass an array with the same number of items as the content to the layout, you just need to pass the number of items.
Finally I made the assert for the size of the columns more strict, since using a set of columns that were under 100 could cause the items to not fit into rows as desired. I fixed the tests that make sure we assert properly.