Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "named blocks" #1472

Open
lifeart opened this issue Jan 29, 2021 · 6 comments
Open

Show "named blocks" #1472

lifeart opened this issue Jan 29, 2021 · 6 comments

Comments

@lifeart
Copy link
Contributor

lifeart commented Jan 29, 2021

it will be great to have ability to see "named blocks" usage in component explorer

why?

in ember v3.25.0-beta.1 named blocks enabled

emberjs/ember.js#19318

https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md

@RobbieTheWagner
Copy link
Member

@lifeart how exactly would you like this feature to work?

@lifeart
Copy link
Contributor Author

lifeart commented Jan 29, 2021

@rwwagner90 I think it may be <:slotName><InternalComponentIfExists /></:slotName> in component explorer, if there is no components inside slot (but thers is some dom nodes), it may be <:slotName /> .

@RobbieTheWagner
Copy link
Member

@lifeart would the slots be selectable? If so, what data would we show?

@lifeart
Copy link
Contributor Author

lifeart commented Jan 29, 2021

Yes, I think slots should be selectable, and we could show slot's position arguments

{{yield (hash a=1) "foo" "bar" to="heder"}}

[ {a: 1}, "foo", "bar" ]

@RobbieTheWagner RobbieTheWagner changed the title it will be great to have ability to see "named blocks" usage Show "named blocks" Jan 29, 2021
@chancancode
Copy link
Member

I would like to see this, but right now we don't really have the information to do it from the debug render tree. So the first step would be to make that work, and then we can work out the display format here

@lifeart
Copy link
Contributor Author

lifeart commented Mar 11, 2021

@chancancode follow-up request - have ability to see "if"s and "each" blocks (areas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants