Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ember-debug-handlers for better deprecation support #430

Closed
rwjblue opened this issue Jul 22, 2015 · 3 comments
Closed

Use ember-debug-handlers for better deprecation support #430

rwjblue opened this issue Jul 22, 2015 · 3 comments
Labels

Comments

@rwjblue
Copy link
Member

rwjblue commented Jul 22, 2015

RFC#65 was implemented behind a feature flag in Ember in emberjs/ember.js#11833, and all deprecations updated to include id and until (tracked in emberjs/ember.js#11835).

I created a polyfill for usage with prior Ember versions (rwjblue/ember-debug-handlers-polyfill) that the inspector can use to make tracking down and managing deprecations much easier.

A couple of ideas:

  • hide "non-critical" (ones that are being removed more than two versions from now) deprecations in the deprecations pane (with some sort of toggle to show all)
  • allow focusing on a single deprecation, by calling Ember.Debug.registerDeprecationHandler and throwing for the id or deprecation message in question

Thoughts?

@teddyzeenny
Copy link
Contributor

👍 Will work on it for version 1.9.

@RobbieTheWagner
Copy link
Member

@rwjblue @teddyzeenny do we still want to do anything here or can we close this?

@RobbieTheWagner
Copy link
Member

I think with collapsible deprecations, and the ability to flush deprecations now, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants