Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Unification Support #916

Closed
RobbieTheWagner opened this issue Jan 11, 2019 · 9 comments
Closed

Module Unification Support #916

RobbieTheWagner opened this issue Jan 11, 2019 · 9 comments
Labels

Comments

@RobbieTheWagner
Copy link
Member

Module unification is still in flux, but it is starting to become more prevalent. We need to investigate the changes necessary to support the new file layout.

@AvremelM
Copy link

Is this being tracked somewhere else now?

@RobbieTheWagner
Copy link
Member Author

@HodofHod #931

@AvremelM
Copy link

@rwwagner90 That doesn't seem to explicitly include MU support, is it implied in Octane support? And does that mean it will support MU apps that aren't on Octane?

@RobbieTheWagner
Copy link
Member Author

@HodofHod Octane === MU, I believe. I don't think you can use MU by itself.

@AvremelM
Copy link

AvremelM commented Jan 31, 2019

@rwwagner90 Definitely not the case. I am currently using MU on Ember 3.6.

Edit: https://discuss.emberjs.com/t/readers-questions-can-i-start-using-module-unification-in-my-app/15029

@RobbieTheWagner
Copy link
Member Author

@HodofHod Either way MU layout === Octane layout, so Octane support means MU support. I don't think we'll be attempting to support nonstandard MU with older apps. Do you know of things that are currently broken in inspector in your app?

@AvremelM
Copy link

Definitely the Data tab is broken, since the ContainerDebugAdapter can't find the models properly. I've manually hacked together a fix for my app for that by overriding it in an initializer.

Also, all components show up as {{@ember/component}}, but I'm not sure if that's MU related or something else (native classes or something).

I'm not aware that MU sans-Octane is nonstandard, won't it be effectively the same since the main difference between MU and Classic is the ember-resolver, which is (I think) mostly independent of Ember versions?

@RobbieTheWagner
Copy link
Member Author

I'm saying all of the changes with regards to Native Classes, MU, angle bracket components, etc are a part of Octane. I don't think they are intended to be used piecemeal, but are intended to be used as Octane.

As far as I know, long term support will not be given for taking any one feature of Octane and bolting it onto older apps. With this in mind, I am saying we'll support Octane, and its features, but will not be attempting to support every one off case.

Does that make sense? Perhaps I am not explaining what I mean here correctly.

@AvremelM
Copy link

AvremelM commented Feb 1, 2019

Thanks, I think I understand now. I've just never seen anything that indicates MU, angle bracket components, Native Classes et al. are only intended to be used in Octane. E.g, Native Classes are officially supported public api in Ember 3.6, and angle bracket components are supported in Ember 3.4.

Regardless, I'm sure if the inspector supports those features in Octane, it'll work for me as well, so that's good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants