Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still expects handlebars to be in bower_components #133

Closed
kamal opened this issue Feb 8, 2015 · 5 comments
Closed

Still expects handlebars to be in bower_components #133

kamal opened this issue Feb 8, 2015 · 5 comments

Comments

@kamal
Copy link

kamal commented Feb 8, 2015

With the 1.10.0 release, I planned on getting rid of handlebars entirely. However it seems ember-qunit and ember-test-helpers still require handlebars to be around.

@rwjblue
Copy link
Member

rwjblue commented Feb 8, 2015

How so? Can you elaborate?

@gmajoulet
Copy link

The 1.10.0 release is not tagged, so I guess people are still getting the v0.2.5.

@rwjblue
Copy link
Member

rwjblue commented Feb 10, 2015

1.10.0 is a release of Ember (not ember-qunit). ember-qunit is still 0.2.x.

@gmajoulet
Copy link

From the Ember release note: http://emberjs.com/blog/2015/02/07/ember-1-10-0-released.html

To smoothly upgrade to 1.10 and HTMLBars, Ember-CLI users should update
to a version at or after 0.1.12 and then remove their application's Handlebars
dependency. Ember App-Kit users should upgrade to Ember-CLI.

So I guess we all removed the dependency to Handlebars. But the last release still imports a link to bower_components/handlebars/handlebars.js. I guess it should work with this last commit though rwjblue@eb9973c

@rwjblue
Copy link
Member

rwjblue commented Feb 10, 2015

@gmajoulet - The last release of ember-qunit does not require Handlebars. For upgrading an Ember CLI app to use Ember 1.10.0 (again not related to ember-qunit at all), make these changes: rwjblue/components-in-subdirs@78e7ed2.

@rwjblue rwjblue closed this as completed Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants