Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make beforeEach & afterEach respect returned promises #192

Closed
ef4 opened this issue Sep 28, 2015 · 1 comment
Closed

Make beforeEach & afterEach respect returned promises #192

ef4 opened this issue Sep 28, 2015 · 1 comment

Comments

@ef4
Copy link
Collaborator

ef4 commented Sep 28, 2015

Returning a promise from beforeEach or afterEach does not cause the tests to wait. This is inconsistent with test, which does wait. The practical workaround today is to do:

beforeEach(assert) {
  let done = assert.async();
  somethingAsynchronous().then(done);
}

But we should make promises work too.

Related issues:

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

I'm pretty sure this works by now, so I'm going to go ahead and close this issue. Please reopen if this is still a problem.

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants