Tests broke between 0.4.11 and 0.4.12

[luketheobscure]

For whatever reason, nearly all of our tests broke after upgrading to 0.4.12. We are on Ember 1.8.1. The all die with some variant of:

not ok 151 PhantomJS 1.9 - FooBarTest
    ---
        actual: >
            null
        message: >
            Promise rejected before FooBar Test Descriptions: Requested keys of a value that is not an object.

[rwjblue]

Thanks for reporting! Can you provide a reproduction?

I'll try to dig in more tonight...

[rwjblue]

On second review, seems like this is because we are calling:

Object.keys(Ember.inject)

Which is not a thing until 1.10 or 1.11. I'll get it hot fixed and released shortly...

[ef4]

Oops, that was my bad.

We are highly likely to break more things like this unless we commit to continuous integration testing of these increasingly stale ember versions.

It may be simpler to just do a bigger version bump of ember-qunit, and people who are stuck on old ember can also stay stuck on old ember-qunit.

[rwjblue]

Ya, I'm game with testing back to older versions (we were originally testing ember-test-helpers back to 1.10, but should be able to go back further). I'm also fine with a major version bump, but I'd rather it be due to a larger issue than this...

[ef4]

ember-test-helpers currently tests back to 1.11.3. That is where we should have tried to catch this problem.

But I am pretty confident that other things are also broken if you go back that far, and the test suite is not going to just pass.

[rwjblue]

Should be fixed in 0.4.13. Closing for now, but can reopen if its still an issue for y'all...