Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in models with two words from 0.4.9 to 0.4.10 #199

Closed
adam-knights opened this issue Oct 16, 2015 · 3 comments
Closed

Regression in models with two words from 0.4.9 to 0.4.10 #199

adam-knights opened this issue Oct 16, 2015 · 3 comments

Comments

@adam-knights
Copy link

I was trying out 0.4.13 and nine of my tests started failing when they were fine in 0.4.9.

The tests that fail are the simple Unit - Model - Exists type ones. i.e I have a test Unit | Model | account: it exists that fails with No model was found for 'account-type'

With the test being:

import { moduleForModel, test } from 'ember-qunit';

moduleForModel('account', 'Unit | Model | account', {
  // Specify the other units that are required for this test.
  needs: ['model:contact', 'model:address', 'model:order', 'model:accountType', 'model:price', 'model:orderItem', 'model:membershipType']
});

test('it exists', function(assert) {
  var model = this.subject();

  assert.ok(!!model);
});

All my other unit model tests that need a model with 'two words' fail similarly, such as order-item, measurement-unit etc.

I did some more digging and the regression occurs in 0.4.10 so looking at the commits it maybe happened when ember-test-helpers was updated from 0.5.8 to 0.5.9?

@adam-knights adam-knights changed the title Regression in models with two words from 0.4.9 to 0.4.13 Regression in models with two words from 0.4.9 to 0.4.10 Oct 16, 2015
@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2015

I suspect that this and emberjs/ember-test-helpers#108 share the same root problem.

@rwjblue
Copy link
Member

rwjblue commented Oct 20, 2015

I've got a solution that I am working on, and will close this in favor of tracking in emberjs/ember-test-helpers#108 (because the issue is ultimately upstream in ember-test-helpers).

@adam-knights
Copy link
Author

0.4.15 resolved this as expected, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants