Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs fails with single-character underscore helper name #201

Closed
rtm opened this issue Oct 20, 2015 · 3 comments
Closed

needs fails with single-character underscore helper name #201

rtm opened this issue Oct 20, 2015 · 3 comments

Comments

@rtm
Copy link

rtm commented Oct 20, 2015

We use a single-underscore helper for localization. This works fine. The problem is that unit tests fail. Even when I specify needs: ['helper:_'], it still complains that it cannot find the helper. Is there something special about the _? When I replace _ everywhere with gettext, things work fine.

@rwjblue
Copy link
Member

rwjblue commented Oct 20, 2015

In general (aside from a bug in the globals resolver causing the demo to use App.Helper instead of App._Helper) this seems to work properly: http://rwjblue.jsbin.com/puhuji in both a component integration test and a component unit test.

Please provide a minimal reproduction (demo ember-cli repo is perfect) showing the issue you are having.

@rwjblue
Copy link
Member

rwjblue commented Oct 21, 2015

It is also possible that this is suffering from the issue that emberjs/ember-test-helpers#113 is fixing (essentially that the resolver is not properly normalizing), but it is going to be very hard to isolate/track down (if that PR doesn't "magically" fix the issue) without a reproduction.

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

closing due to inactivity

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants