Where does the "ember.run" belong when integration testing?

[toranb]

I've become a huge integration test fan boy recently and find that I often need to wrap my trigger (change/input/etc) with ember.run like so

test('on change will work as expected', function(assert) {
    let issue = Issue.create({id: 1, subject: 'Broken'});
    let one = Status.create({id: 8, name: 'Open', issues: []});
    let two = Status.create({id: 9, name: 'Closed', issues: [1]});
    this.set('model', issue);
    this.set('statuses', Ember.A([one, two]));
    this.render(hbs`{{issue-detail model=model statuses=statuses}}`);
    let $component = this.$(".my-select-here");
    Ember.run(() => {
        $component.val(9).trigger('change');
    });
    //assert some stuff
});

The production select looks something like this

<select class="form-control my-select-here" onchange={{action "changed_status" value="target.value"}}>
{{#each statuses as |status|}}
<option value={{status.id}} selected={{is-equal model.status.id status.id}}>{{status.name}}</option>
{{/each}}
</select>

In the action itself I do some type of "set" (which causes the runloop error to pop up in the test you see above). Should I wrap the trigger change in the intergration test or instead should I ember.run in the action that's invoked from the "onchange" event (and why) ?

https://github.com/toranb/ember-cli-selectize/blob/master/tests/integration/components/issue-detail-test.js#L24-L26

[rwjblue]

In 2.2 closure actions will be properly wrapped in a run loop (just like non-closure actions).

For now I would add to your tests (or make a simple helper function that you use). I intend to expose some nice helpers for component integration tests (things like 'click', 'fillin', etc that you get for free in acceptance tests), so making a small helper function would make that an easy refactor in the future.

[toranb]

Glad to know I got this right the first time around :)

thanks for the quick reply @rwjblue